China DOS Union

I encountered a problem. For example, I have hundreds of.pdf files, such as:
central aaa 01.pdf
akurss bbs 99.pdf
sskpk p12 980 ok.pdf
airchina lufthansa uk mu500.pdf
92 years anniver.pdf
.........
What I want to do is to compile a batch file xxx.cmd. Running it once can automatically change the "spaces" in all the above.pdf files to "-". After running the xxx.cmd file, the above PDF files will be renamed as follows and saved:
central-aaa-01.pdf
akurss-bbs-99.pdf
sskpk-p12-980-ok.pdf
airchina-lufthansa-uk-mu500.pdf
92-years-anniver.pdf
.........
How to write it? Can you give an example? Thank you.

[ Last edited by tommy725 on 2007-4-2 at 06:55 AM ]

This is the original content in the quote section:

1. @echo off
   
2. for /f "delims=" %%a in ('dir /b /a *.pdf') do set "old_name=%%a" &call :re_name
   
3. goto exit
   
4. :re_name
   
5. set "new_name=%old_name: =-%"
   
6. ren "%old_name%" "%new_name%"
   
7. :exit
   

BJSH发表于： 2007-03-31 09:37

[ Last edited by bjsh on 2007-3-31 at 09:47 AM ]

Why is there no problem when I try it myself?? Please tell me the error message.

Thanks a lot, bjsh. I'll give it a try. But I still don't understand. If you can explain the meaning or function of each sentence, I would be even more grateful.

对于这一句话？想问个问题？

('dir /b /a *.pdf')里面的参数是不是只会执行一次？然后把把所有变量放内存里？等程序一个一个的读取？
当里面读取的内容非常多的时候。会不会造成机器假死？

For the sentence? Want to ask a question?

Are the parameters inside ('dir /b /a *.pdf') only executed once? Then put all variables into memory? Wait for the program to read one by one?
When there are a lot of content read inside. Will it cause the machine to freeze?

Just now I made a mistake.

@echo off
setlocal enabledelayedexpansion
for %%h in (*.pdf) do (
set str=%%h
set str=!str: =-!
ren "%%h" "!str!")

[ Last edited by huzixuan on 2007-4-1 at 08:54 AM ]

Thank you everyone, can I test like this? Edit file.cmd, then write the code in and save it, then run this file in the current folder. There are three test.pdf documents in the current folder. But why does this result appear:
a duplicate file name exists,or the file can not be found
a duplicate file name exists,or the file can not be found
a duplicate file name exists,or the file can not be found

Does directly running the one I wrote also have this kind of error???

It's good, but I can't understand it. It's really frustrating~~~~

I ran
@echo off
for /f "delims= " %%a in ('dir /b/a *.pdf') do
set "old_name=%%a" &call :re_name
goto exit
:re_name
set "new_name=%old_name:=-%"
ren "%old_name%" "%new_name%"
:exit
After running, it said the syntax of the command is incorrect.

What I wrote just now, which can be renamed after testing

@echo off&setlocal enabledelayedexpansion
for /f "delims=." %%a in ('dir /a-d /b *.pdf') do (
set str=%%a
set str=!str: =-!
ren "%%a".pdf !str!.pdf
)
pause


But your sskpk p12 980 ok.pdf has two spaces, so the renamed one will be sskpk--p12-980-ok.pdf. Is it okay to use it like this

Two spaces are my input error. If spaces can be changed to "-", it's okay.

ren "* *.pdf" "*-*.pdf"