China DOS Union

Nowadays, many MP3 players can display lyrics. For normal display, the lyric file (*.lrc) must have the same name as the song file (*.mp3) and be in the same directory.!!!
But it's often difficult for us to find out whether there is a corresponding lyric file. So I made a batch script referring to similar previous posts, although there are many deficiencies.^^ I sincerely ask all seniors for your valuable advice.
Suppose the drive letter corresponding to the MP3 is G:\
G:\Music is a special directory for storing songs. Because many current MP3 players can read multiple levels of directories, so categorizing different types of songs into different directories can make using them more convenient.
Suppose there are two more directories under G:\Music
G:\Music\01
G:\Music\02
The batch script is as follows.

@echo off
del G:\list.txt>nul 2>nul
echo ---G:Music\01 >G:\list.txt
cd /d G:\music\01
for %%i in (*.mp3 *.wma) do (if not exist %%~ni.lrc echo %%~ni>>G:\list.txt)
echo ---G:Music\02 >>G:\list.txt
cd /d G:\Music\02
for %%i in (*.mp3 *.wma) do (if not exist %%~ni.lrc echo %%~ni>>G:\list.txt)
notepad G:\list.txt
exit

It has been tested to work. I'm a newbie. I feel awkward to write so many lines of code for such a simple operation. I hope everyone can help simplify it. If there are any problems, I also sincerely ask everyone to point them out.

[ Last edited by junyee on 2006-10-1 at 22:49 ]

@echo off
echo _____________________G:Music\01 >G:\list.txt
cd /d G:\music\01
for %%i in (*.mp3 *.wma) do if not exist %%~ni.lrc echo %%~ni>>G:\list.txt
echo _____________________G:Music\02 >>G:\list.txt
cd /d G:\Music\02
for %%i in (*.mp3 *.wma) do if not exist %%~ni.lrc echo %%~ni>>G:\list.txt
start G:\list.txt
exit

The landlord's code is written well!!! I removed del because the line echo ---G:Music\01 >G:\list.txt below will refresh the content. (As long as the file attribute is not read-only!)

The two for statements are the nesting of two compound statements, for and if, and parentheses are not needed.

The line notepad G:\list.txt is changed to start G:\list.txt because in DOS, to open an application, since the suffixes are all associated, the system will automatically call Notepad to open it.

[ Last edited by pengfei on 2006-10-1 at 23:18 ]

Actually, your code is already quite concise. The only thing that can be modified is to optimize some parts of the code. Especially, there is a problem with the line `notepad G:\list.txt`. Once you use this line, the batch processing window will not exit until G:\list.txt is closed, and the exit statement at the end can be omitted. Modify your code as follows:

@echo off del /a /f /q G:\list.txt 2>nul echo ---G:Music\01 >>G:\list.txt cd /d G:\music\01 for %%i in (*.mp3 *.wma) do if not exist %%~ni.lrc echo %%~ni>>G:\list.txt echo ---G:Music\02 >>G:\list.txt cd /d G:\Music\02 for %%i in (*.mp3 *.wma) do if not exist %%~ni.lrc echo %%~ni>>G:\list.txt start G:\list.txt

Just after posting, I found that pengfei has already given the code on the second floor. Hehe, he's really quick.

But it's not appropriate to remove the del statement because I don't know the attributes of G:\list.txt. If it's in read-only attribute, the echo redirection to G:\list.txt will not be able to write! So my code still retains the del statement, and adds the /a /f parameters to force deletion, and adds the silent parameter /q; also considering that G:\list.txt may not exist, so uses 2>nul to shield the display of error messages on the screen.

[ Last edited by namejm on 2006-10-1 at 22:09 ]

kcOh, I still feel it's not concise enough..
But, is there any way to further simplify the above command? Because
echo ---G:Music\01 >>G:\list.txt
cd /d G:\music\01
for %%i in (*.mp3 *.wma) do if not exist %%~ni.lrc echo %%~ni>>G:\list.txt
echo ---G:Music\02 >>G:\list.txt
cd /d G:\Music\02
for %%i in (*.mp3 *.wma) do if not exist %%~ni.lrc echo %%~ni>>G:\list.txt
What's done here is repetitive actions with only different directory names. If there are many folders under G:\music, it will be even longer?

You can try the following code (temporarily not considering various possible errors, such as the problem of files with the same name in mp3 format and wma format):
@echo off setlocal enabledelayedexpansion del /a /f /q G:\list.txt 2>nul for /r %%i in (.) do ( set route=%%i set route=!route:~0,-2! echo -------!route!>>G:\list.txt for %%j in ("%%i\*.mp3" "%%i\*.wma") do ( if not exist %%~nj.lrc echo %%~nj>>G:\list.txt ) ) start notepad G:\list.txt

All folders in the current directory are okay.
Note: Folders should not have spaces or sensitive characters.

@echo on cd.>list.txt setlocal enabledelayedexpansion for /f %%i in ('dir/ad/b/s') do ( set D=%%i call :List !D:%cd%\=!) exit :List for %%i in ("%1\*.mp3" "%1\*.wma") do if not exist "%1\%%~ni.lrc" >>list.txt echo %1\%%~ni goto :eof

If you want to distinguish between MP3 format and WMA format, change it to ">>list.txt echo %1\%%i"

```
@echo off

del/a/f/q list.txt 2>nul & for /f "delims=" %%i in ('dir/s/a-d/b *.mp3 *.wma') do ( if not exist "%%~di%%~pi%%~ni.lrc" echo %%i>>list.txt )

start list.txt
```

I also try

[ Last edited by NaturalJ0 on 2006-10-2 at 00:01 ]

Everyone's writing is pretty good. I'll also post a section. Traverse each directory under the current directory. List the song names without lyrics and note the directory they are in. The problem of spaces in the path should be handleable. It will also search the current directory, and if there are no files, it will prompt that no files are found...

Moderator namejm said about read-only files, which cannot be written. This is very important, so still choose DEL. If there are two formats of files with the same name in the same directory, this cannot be handled in any way, because there can only be one lrc, so the other format file has to be renamed.

@echo off set route=%cd% if exist list.txt del /a list.txt setlocal enabledelayedexpansion for /r %%m in (.) do ( set list=%%m set list=!list:~0,-2! cd /d !list! set num= for /f "tokens=*" %%i in ('dir /a-d /b *.mp3 *.wma') do ( if "!num!"==" " echo ===!list!===>>"%route%\list.txt" & set num= if not exist %%~ni.lrc echo %%i>>"%route%\list.txt" ) ) start "" "%route%\list.txt"

For more music types, add according to the current format in the second for statement.

[ Last edited by pengfei on 2006-10-2 at 05:34 ]

Found the code from user namejm on floor 5. It turns out that you can list matching files in a directory without using dir. Hehe~ Learned something...

The following code has the same function as the one on floor 8, completed with a single for. The speed is also decent!

@echo off set route=%cd% set term= set take=set list=%%~dpi if exist file.txt del /a file.txt setlocal enabledelayedexpansion for /f "tokens=*" %%i in ('dir /s /a-d /b *.mp3 *.wma') do ( !take! if "!list!"=="%%~dpi" ( set take= ) else ( set term= & set take=set list=%%~dpi ) if "!term!"==" " echo ===%%~dpi===>>"%route%\file.txt" & set term= if not exist %%~dpni.lrc echo %%~nxi>>"%route%\file.txt" ) start "" "%route%\file.txt"

[ Last edited by pengfei on 2006-10-2 at 05:34 ]

Simple command-line display version:
@for /r %i in (*.mp3 *.wma) do @if not exist "%~ni.lrc" echo. %%i

Strictly formatted version:
@del /a /f /q G:\list.txt 2>nul @for /r %%i in (*.mp3 *.wma) do @if not exist "%%~dpni.lrc" call :sub "%%i" @goto :EOF :sub @if "%~dp1" NEQ "%dir%" set "dir=%~dp1" &echo. ---%dir%>>G:\list.txt @if not exist "%~dpn1.lrc" echo. %~n1>>G:\list.txt @goto :EOF

:sub
@if "%~dp1" NEQ "%dir%" set "dir=%~dp1" &echo. ---%dir%>>G:\list.txt
@if not exist "%~dpn1.lrc" echo. %~n1>>G:\list.txt
@goto :EOF

Found that %%i is reassigned to %1, and it can still use the variable expansion of for.....

It would be nice if we could get something like Qianqian Jingting that automatically downloads lyrics.

Much more concise than I thought!

@echo off&setlocal enabledelayedexpansion&color 1f
mode con:cols=50 lines=25
title Delete Unmatched Lyrics from MP3 http://hi.baidu.com/xinghuo
set n=0
if "%~1"=="" (
echo Please directly drag and drop the folder containing music onto this file
ping /n 6 127.0.0.1>nul&exit
) else (
echo Current detection directory is: %~1
)
echo _________
for %%i in ("%1\*.lrc") do (
if not exist %1\%%~ni.wma (
if not exist %1\%%~ni.mp3 set/a n+=1&set name!n!=%%i&echo %%~nxi --Not Find )
)
echo.
if %n%==0 echo All lyrics are matched&echo Program from: http://hi.baidu.com/xinghuo&pause>nul&exit
set /p sure=Do you want to delete these lyric files?(Y), press other keys to exit:
if /i "%sure%"=="y" (
cls
echo Deleting...
for /l %%a in (1,1,%n%) do (
del "!name%%a!" 2>nul
)
echo.&echo ^^_^^, The world is quiet!
echo Program from: http://hi.baidu.com/xinghuo
)
pause>nul
exit